Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix #1805: Show publisher name in the tipping panel #1807
Merged
Conversation
| $0.layer.borderColor = UIColor.white.cgColor | ||
| $0.layer.borderWidth = 2.0 | ||
| } | ||
|
|
||
| let publisherNameLabel = UILabel().then { | ||
| $0.appearanceTextColor = .white | ||
| $0.font = .systemFont(ofSize: 20.0, weight: .medium) |
This comment has been minimized.
This comment has been minimized.
iccub
Oct 28, 2019
Contributor
What if the name is very long, should we shrink it or break to few lines, have you tested it?
How do we do it for other places with pub names?
This comment has been minimized.
This comment has been minimized.
kylehickinson
Oct 28, 2019
Author
Contributor
I thought about it, in panel we make it have 2 lines but I think everywhere else it is truncated
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
iccub
Oct 28, 2019
Contributor
Do you want to add it @kylehickinson?
There's method for truncating strings in StringExtensions
This comment has been minimized.
This comment has been minimized.
kylehickinson
Oct 28, 2019
Author
Contributor
It will truncate automatically as its constrained to the right side, no need to truncate manually :)
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.


kylehickinson commentedOct 28, 2019
Please use rebase merge strategy
Summary of Changes
This pull request fixes issue #1805
Submitter Checklist:
NSLocalizableString()Screenshots:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement