Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1805: Show publisher name in the tipping panel #1807

Merged
merged 2 commits into from Oct 28, 2019

Conversation

@kylehickinson
Copy link
Contributor

kylehickinson commented Oct 28, 2019

Please use rebase merge strategy

Summary of Changes

This pull request fixes issue #1805

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Screenshots:

Regular Media
Simulator Screen Shot - iPhone 11 Pro - 2019-10-28 at 15 22 43 Simulator Screen Shot - iPhone 11 Pro - 2019-10-28 at 15 22 52

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).
@kylehickinson kylehickinson requested review from Brandon-T and iccub Oct 28, 2019
$0.layer.borderColor = UIColor.white.cgColor
$0.layer.borderWidth = 2.0
}

let publisherNameLabel = UILabel().then {
$0.appearanceTextColor = .white
$0.font = .systemFont(ofSize: 20.0, weight: .medium)

This comment has been minimized.

Copy link
@iccub

iccub Oct 28, 2019

Contributor

What if the name is very long, should we shrink it or break to few lines, have you tested it?
How do we do it for other places with pub names?

This comment has been minimized.

Copy link
@kylehickinson

kylehickinson Oct 28, 2019

Author Contributor

I thought about it, in panel we make it have 2 lines but I think everywhere else it is truncated

This comment has been minimized.

Copy link
@srirambv

srirambv Oct 28, 2019

Contributor

On Android it truncates the pub name like this
image

So probably follow the same. Desktop has bigger text area so it shows on a new line

This comment has been minimized.

Copy link
@iccub

iccub Oct 28, 2019

Contributor

Do you want to add it @kylehickinson?
There's method for truncating strings in StringExtensions

This comment has been minimized.

Copy link
@kylehickinson

kylehickinson Oct 28, 2019

Author Contributor

It will truncate automatically as its constrained to the right side, no need to truncate manually :)

This comment has been minimized.

Copy link
@kylehickinson

kylehickinson Oct 28, 2019

Author Contributor

Simulator Screen Shot - iPhone 11 Pro - 2019-10-28 at 15 43 33

@iccub
iccub approved these changes Oct 28, 2019
@kylehickinson kylehickinson merged commit 160d166 into development Oct 28, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@kylehickinson kylehickinson deleted the tipping-pub-name branch Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.