Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1814: Restore correct copy for ads opt-in when region is available #1815

Merged
merged 1 commit into from Oct 29, 2019

Conversation

@kylehickinson
Copy link
Contributor

kylehickinson commented Oct 29, 2019

Somehow lost this screen's copy at some point? Probably when removing agreement flow

Summary of Changes

This pull request fixes issue #1814

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Screenshots:

Simulator Screen Shot - iPhone 11 Pro - 2019-10-29 at 10 31 25

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).
@kylehickinson kylehickinson requested review from Brandon-T and iccub Oct 29, 2019
@kylehickinson kylehickinson force-pushed the onboarding-ads-opt-in-fix branch from 8d56096 to 4a3a741 Oct 29, 2019
@iccub
iccub approved these changes Oct 29, 2019
@kylehickinson kylehickinson merged commit 5242cee into development Oct 29, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@kylehickinson kylehickinson deleted the onboarding-ads-opt-in-fix branch Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.