Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1808, Fix #1809: Fix tipping screen rotation & multitasking layout #1819

Merged
merged 1 commit into from Oct 29, 2019

Conversation

@kylehickinson
Copy link
Contributor

kylehickinson commented Oct 29, 2019

In iOS 13, traitCollectionDidChange no longer is called on init and instead is given a predicted trait collection therefore we need to make sure to use that predicted trait collection on init in case it never changes.

Summary of Changes

This pull request fixes issue #1808
This pull request fixes issue #1809

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).
In iOS 13, `traitCollectionDidChange` no longer is called on `init` and instead is given a predicted trait collection therefore we need to make sure to use that predicted trait collection on `init` in case it never changes.
@kylehickinson kylehickinson requested review from Brandon-T, jhreis and iccub Oct 29, 2019
@iccub
iccub approved these changes Oct 29, 2019
@kylehickinson kylehickinson merged commit 801c11a into development Oct 29, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@kylehickinson kylehickinson deleted the tipping-traits branch Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.