Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix #1808, Fix #1809: Fix tipping screen rotation & multitasking layout #1819
Conversation
In iOS 13, `traitCollectionDidChange` no longer is called on `init` and instead is given a predicted trait collection therefore we need to make sure to use that predicted trait collection on `init` in case it never changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kylehickinson commentedOct 29, 2019
•
edited by iccub
In iOS 13,
traitCollectionDidChangeno longer is called oninitand instead is given a predicted trait collection therefore we need to make sure to use that predicted trait collection oninitin case it never changes.Summary of Changes
This pull request fixes issue #1808
This pull request fixes issue #1809
Submitter Checklist:
NSLocalizableString()Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement