Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2539: Super Referrer Improvements (Clipboard) #2535

Merged
merged 16 commits into from May 25, 2020
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Fixed S3 bucket endpoint for enterprise builds.

  • Loading branch information
jhreis committed May 21, 2020
commit 98253b6c50522a7c20293658549923e66a7d95fd
@@ -30,6 +30,7 @@ public class UserReferralProgram {
return Bundle.main.infoDictionary?[key] as? String
}

// This should _probably_ correspond to the baseUrl for NTPDownloader
let host = AppConstants.buildChannel == .developer ? HostUrl.staging : HostUrl.prod

guard let apiKey = getPlistString(for: UserReferralProgram.apiKeyPlistKey)?.trimmingCharacters(in: .whitespacesAndNewlines) else {
@@ -22,8 +22,10 @@ class NTPDownloader {
case sponsor

var resourceBaseURL: URL? {
let baseUrl = AppConstants.buildChannel.isPublic ? "https://mobile-data.s3.brave.com/"
: "https://mobile-data-dev.s3.brave.software"
// This should _probably_ correspond host for URP
let baseUrl = AppConstants.buildChannel == .developer
? "https://mobile-data-dev.s3.brave.software"
: "https://mobile-data.s3.brave.com/"

switch self {
case .superReferral(let code):
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.