Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2584: No longer check clipboard if ref code exists on launch. #2585

Merged
merged 27 commits into from May 27, 2020

Conversation

@jhreis
Copy link
Contributor

jhreis commented May 27, 2020

Summary of Changes

This pull request fixes #2584

No longer allow ref codes to be overwritten from clipboard on subsequent launches when network request fails.

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

  1. Copy a referral link (or retrieve from website) F83AB73F-9852-4F01-ABA8-7830B8825993:ABC123
  2. Disable internet
  3. Launch Brave (reads from clipboard)
  4. See ref code in settings
  5. Force quit Brave
  6. Copy new ref code (F83AB73F-9852-4F01-ABA8-7830B8825993:XYZ789)
  7. Re-open Brave (internet still off)
  8. Look at settings, should still see same / old ref-code
  9. Quite Brave
  10. Enable internet
  11. Re-open Brave
  12. Check logs (should see some server response, either invalid code, or a download id)

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).
jhreis and others added 26 commits May 11, 2020
Now properly ping the `nonua` endpoint if device receives a ref code independent on the Brave API.
@jhreis jhreis requested review from jumde and iccub May 27, 2020
@iccub
iccub approved these changes May 27, 2020
@jumde jumde requested review from iccub and jumde May 27, 2020
@jumde
jumde approved these changes May 27, 2020
@jhreis jhreis merged commit fb96ea8 into development May 27, 2020
2 checks passed
2 checks passed
SonarCloud Code Analysis Quality Gate passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jhreis jhreis deleted the fix-2584 branch May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.