Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix #2584: No longer check clipboard if ref code exists on launch. #2585
+7
−1
Conversation
Now properly ping the `nonua` endpoint if device receives a ref code independent on the Brave API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jhreis commentedMay 27, 2020
•
edited by srirambv
Summary of Changes
This pull request fixes #2584
No longer allow ref codes to be overwritten from clipboard on subsequent launches when network request fails.
Submitter Checklist:
NSLocalizableString()Test Plan:
F83AB73F-9852-4F01-ABA8-7830B8825993:ABC123F83AB73F-9852-4F01-ABA8-7830B8825993:XYZ789)eBraveScreenshots:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement