Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear playlistItems when navigating on YT #2587

Open
wants to merge 14 commits into
base: feature/Playlists
from

Conversation

@jamesmudgett
Copy link
Contributor

jamesmudgett commented May 28, 2020

Summary of Changes

This pull request fixes #

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).
@jamesmudgett jamesmudgett requested a review from Brandon-T May 28, 2020
@jamesmudgett
Copy link
Contributor Author

jamesmudgett commented May 28, 2020

Few small fixes like clear playlist items when switching between urls (especially YT), new styling for playlist Now Playing bar, icons for 2x 3x.

@jamesmudgett jamesmudgett force-pushed the feature/Playlists-james branch from 0418c9e to f44ec9b May 28, 2020
@Brandon-T Brandon-T force-pushed the feature/Playlists-james branch 2 times, most recently from 7f06dfc to f44ec9b Jun 2, 2020
@Brandon-T Brandon-T force-pushed the feature/Playlists branch from e1aa572 to 5924d25 Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.