Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix #513, share correct item from history/bookmark panels. #517
Conversation
danishjafri88
merged commit 38a0ebf
into
brave:development
1 check failed
1 check failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
iccub commentedNov 30, 2018
•
edited
The previous implementation shared url of selected tab rather than the link we tapped in history/bookmark panels. Now it should all work
Pull Request Checklist
My patch has gone through review and I have addressed review comments
My patch has a standard commit message that looks like
Fix #123: This fixes the shattered coffee cup!I have updated the Unit Tests to cover new or changed functionality
I have updated the UI Tests to cover new or changed functionality
I have marked the bug with
[needsuplift]I have made sure that localizable strings use
NSLocalizableString()Screenshots
If your patch includes user interface changes that you would like to suggest or that you would like UX to look at, please include them here.
Notes for testing this patch
If useful, please leave notes for QA, explaining what this patch changes and how it can be best tested and verified.