Skip to content

/ brave-ios

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #488: Remove Trackers + Script blocking from global stats view #524

Merged
merged 1 commit into from Nov 30, 2018
Merged

Fix #488: Remove Trackers + Script blocking from global stats view #524

merged 1 commit into from Nov 30, 2018

Conversation

@kylehickinson
Copy link
Contributor

kylehickinson commented Nov 30, 2018

  • Also fixes ads + trackers count in domain-specific shield stats not including trackers count

Pull Request Checklist

  • My patch has a standard commit message that looks like Fix #123: This fixes the shattered coffee cup!
  • I have updated the Unit Tests to cover new or changed functionality
  • I have updated the UI Tests to cover new or changed functionality
  • I have made sure that localizable strings use NSLocalizableString()

Screenshots

simulator screen shot - iphone x - 2018-11-30 at 10 24 11

Notes for testing this patch

None included
@kylehickinson
Fix #488: Remove Trackers + Script blocking from global stats view
Loading status checks…
31df3f9 
- Also fixes ads + trackers count in domain-specific shield stats not including trackers count
@kylehickinson kylehickinson requested review from jhreis and danishjafri88 Nov 30, 2018
@kylehickinson
Copy link
Contributor Author

kylehickinson commented Nov 30, 2018

Added @danishjafri88, to check the localized string part
@jhreis
jhreis reviewed Nov 30, 2018
View changes
Copy link
Contributor

jhreis left a comment

Waiting on copy approval.
@jhreis
jhreis approved these changes Nov 30, 2018
View changes
@jhreis jhreis merged commit cd91a3d into development Nov 30, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jhreis jhreis deleted the global-stats-ui branch Nov 30, 2018
@kylehickinson kylehickinson mentioned this pull request Dec 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhreis jhreis

@danishjafri88 danishjafri88

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@kylehickinson @jhreis
You can’t perform that action at this time.