Skip to content

/ brave-ios

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #631 Scroll issues. #670

Merged
merged 6 commits into from Jan 18, 2019
Merged

Fixed #631 Scroll issues. #670

merged 6 commits into from Jan 18, 2019
Commits on Jan 2, 2019

  1. Corrected constraints relationships. Previously attached to child of …

    @danishjafri88
    danishjafri88 committed Jan 2, 2019 
    …sibling.
    eb1082c

  2. Removed redundant creation of pan gesture when one already exists for…

    @danishjafri88
    danishjafri88 committed Jan 2, 2019 
    … scrollview.
    77926da

  3. Corrected the logic for offset when using iPad(shows tabsbar). The `h…

    @danishjafri88
    danishjafri88 committed Jan 2, 2019 
    …eaderTopOffset` is already clamped by `-topScrollHeight` in scrollWithDelta, where topScrollHeight contains both urlView and tabsBarView.
    083e02f

  4. Improved animation as per apple guidelines.

    @danishjafri88
    danishjafri88 committed Jan 2, 2019
    Loading status checks…
    baed29f

  5. Removed unnecessary setting of maxTouch on scrollView and enabled Zoo…

    @danishjafri88
    danishjafri88 committed Jan 2, 2019
    Loading status checks…
     
    …m for WKWebview.
    1400373

  6. Review Fix

    @danishjafri88
    danishjafri88 committed Jan 2, 2019
    Loading status checks…
    1ec2c4e
You can’t perform that action at this time.