Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experimental-Do not merge] Enhancement + Security Fix For #87 #690

Closed
wants to merge 2 commits into from

Conversation

@danishjafri88
Copy link
Contributor

danishjafri88 commented Jan 9, 2019

Pull Request Checklist

  • My patch has gone through review and I have addressed review comments

  • My patch has a standard commit message that looks like Fix #123: This fixes the shattered coffee cup!

  • I have updated the Unit Tests to cover new or changed functionality

  • I have updated the UI Tests to cover new or changed functionality

  • I have marked the bug with [needsuplift]

  • I have made sure that localizable strings use NSLocalizableString()

Screenshots

If your patch includes user interface changes that you would like to suggest or that you would like UX to look at, please include them here.

Notes for testing this patch

If useful, please leave notes for QA, explaining what this patch changes and how it can be best tested and verified.

WIP
@danishjafri88
Copy link
Contributor Author

danishjafri88 commented Jan 10, 2019

Make Ready

  • Show Toolbars
  • EndEditing
  • Reshow alert on active Tab

Alert Extra Things

  • Start Keyboard notification ops
  • Scrollview to Allow keyboard
  • Scrollview animate to active textfield
  • Manage Scrollview properties and state changes
  • Handle device orientation change
  • Handle Constraints
  • Make test cases

UI

  • Scroll view actions
  • Line separator
  • Textfield UI
  • Min/Max Width/Height
@danishjafri88 danishjafri88 changed the title [WIP] Enhancement + Security Fix For #87 [Experimental-Do not merge] Enhancement + Security Fix For #87 Jul 23, 2019
@jhreis
Copy link
Contributor

jhreis commented Aug 8, 2019

I'm closing this PR, but will keep the branch around. Feel free to submit a draft PR or real PR if this ever gets completed.

@jhreis jhreis closed this Aug 8, 2019
@jhreis jhreis deleted the custom-web-alert branch Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.