Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #734: Shields update on first refresh of an upgraded http page #741

Merged
merged 1 commit into from Jan 16, 2019

Conversation

@kylehickinson
Copy link
Contributor

kylehickinson commented Jan 16, 2019

Seems to be due to a WebKit bug where WKNavigationAction.request.mainDocumentURL is not also upgraded to https, therefore on the first refresh url has https and mainDocumentURL has http. These two properties become aligned once the page is refreshed once.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • My patch or PR title has a standard commit message that looks like Fix #123: This fixes the shattered coffee cup! (or No Bug: <message> if no relevant ticket)
  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New files have MPL-2.0 license header.

Test Plan:

Follow #734

Reviewer Checklist:

  • PR is linked to an issue via Zenhub.
  • Issues are assigned to at least one epic.
  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate test coverage exists to prevent regressions.
  • Adaquate test plan exists for QA to validate (if applicable)
Seems to be due to a WebKit bug where `WKNavigationAction.request.mainDocumentURL` is not also upgraded to https, therefore on the first refresh `url` has https and `mainDocumentURL` has http. These two properties become aligned once the page is refreshed once.
@kylehickinson kylehickinson requested a review from jhreis Jan 16, 2019
@jhreis
jhreis approved these changes Jan 16, 2019
@jhreis jhreis merged commit 11bde80 into development Jan 16, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@jhreis jhreis deleted the schemeless-main-document-url-check branch Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.