Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix #734: Shields update on first refresh of an upgraded http page #741
Conversation
Seems to be due to a WebKit bug where `WKNavigationAction.request.mainDocumentURL` is not also upgraded to https, therefore on the first refresh `url` has https and `mainDocumentURL` has http. These two properties become aligned once the page is refreshed once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kylehickinson commentedJan 16, 2019
•
edited by jhreis
Seems to be due to a WebKit bug where
WKNavigationAction.request.mainDocumentURLis not also upgraded to https, therefore on the first refreshurlhas https andmainDocumentURLhas http. These two properties become aligned once the page is refreshed once.Submitter Checklist:
Fix #123: This fixes the shattered coffee cup!(orNo Bug: <message>if no relevant ticket)NSLocalizableString()Test Plan:
Follow #734
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement