Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFixes #631 Scroll & constraint issues in BrowserViewController #894
Conversation
…sibling.
… scrollview.
…eaderTopOffset` is already clamped by `-topScrollHeight` in scrollWithDelta, where topScrollHeight contains both urlView and tabsBarView.
…m for WKWebview.
…o treating it as non-nil while declaring it as unwrapped optional. Removed old animation code fix which became redundant after update
…nstraints.
danishjafri88
changed the title
|
This feels much better to me, really solid improvements IMO, hopefully others will agree! Just one block of code/comments to remove. |
| @@ -251,20 +244,25 @@ private extension TabScrollingController { | |||
| } | |||
|
|
|||
| func animateToolbarsWithOffsets(_ animated: Bool, duration: TimeInterval, headerOffset: CGFloat, footerOffset: CGFloat, alpha: CGFloat, completion: ((_ finished: Bool) -> Void)?) { | |||
| //NOTE: The issue below (& its fix) is irrelevant now since the the scroll logic is updated, infact the logic further | |||
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
danishjafri88 commentedFeb 12, 2019
•
edited by jhreis
This is a regression PR for #631. Previous PR was reverted because of regression bug relating to constraints not properly set when bottom Toolbar is not visible.
Apart for the above regression fix, following are fixed:
->Youtube header problem
->Redundant Pan Gesture creation
->Mis-aligned constraints relations in BrowserViewController
->Refactored Show/Hide Tab Animation properly
-> Enable Zoom by ignoring viewport scale limit.
-> Removed a part of animation code(Hotfix for older logic) which became source of a jump issue during scroll.
Submitter Checklist:
Fix #123: This fixes the shattered coffee cup!(orNo Bug: <message>if no relevant ticket)NSLocalizableString()Test Plan:
Screenshots:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement