Skip to content

/ brave-ios

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #631 Scroll & constraint issues in BrowserViewController #894

Merged
merged 14 commits into from Apr 11, 2019
Merged

Fixes #631 Scroll & constraint issues in BrowserViewController #894

merged 14 commits into from Apr 11, 2019
Commits on Jan 2, 2019

  1. Corrected constraints relationships. Previously attached to child of …

    @danishjafri88
    danishjafri88 committed Jan 2, 2019 
    …sibling.
    eb1082c

  2. Removed redundant creation of pan gesture when one already exists for…

    @danishjafri88
    danishjafri88 committed Jan 2, 2019 
    … scrollview.
    77926da

  3. Corrected the logic for offset when using iPad(shows tabsbar). The `h…

    @danishjafri88
    danishjafri88 committed Jan 2, 2019 
    …eaderTopOffset` is already clamped by `-topScrollHeight` in scrollWithDelta, where topScrollHeight contains both urlView and tabsBarView.
    083e02f

  4. Improved animation as per apple guidelines.

    @danishjafri88
    danishjafri88 committed Jan 2, 2019
    Loading status checks…
    baed29f

  5. Removed unnecessary setting of maxTouch on scrollView and enabled Zoo…

    @danishjafri88
    danishjafri88 committed Jan 2, 2019
    Loading status checks…
     
    …m for WKWebview.
    1400373

  6. Review Fix

    @danishjafri88
    danishjafri88 committed Jan 2, 2019
    Loading status checks…
    1ec2c4e
Commits on Jan 9, 2019

  1. The footer view will never be nil but is initialised in viewdidload s…

    @danishjafri88
    danishjafri88 committed Jan 9, 2019
    Loading status checks…
     
    …o treating it as non-nil while declaring it as unwrapped optional. Removed old animation code fix which became redundant after update
    8fc0af8
Commits on Jan 23, 2019

  1. Fixes an issue where the footer height is ambiguous due to lack of co…

    @danishjafri88
    danishjafri88 committed Jan 23, 2019 
    …nstraints.
    d0b9ca7

  2. refactored animation option

    @danishjafri88
    danishjafri88 committed Jan 23, 2019
    09cc3e1
Commits on Feb 12, 2019

  1. Aligned fav vc with footer

    @danishjafri88
    danishjafri88 committed Feb 12, 2019
    Loading status checks…
    1f96405
Commits on Apr 9, 2019

  1. resolved conflict

    @danishjafri88
    danishjafri88 committed Apr 9, 2019
    fedf1b6

  2. merge development

    @danishjafri88
    danishjafri88 committed Apr 9, 2019
    Loading status checks…
    7a62569
Commits on Apr 11, 2019

  1. Removed unneeded comment.

    @jhreis
    jhreis committed Apr 11, 2019
    cc1307b

  2. Merge branch 'bugfix/fix.bug.631' of github.com:brave/brave-ios into …

    @jhreis
    jhreis committed Apr 11, 2019
    Loading status checks…
     
    …bugfix/fix.bug.631
    d7f0193
You can’t perform that action at this time.