Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hard-coded theming #138

Open
cezaraugusto opened this issue Sep 10, 2018 · 0 comments
Open

remove hard-coded theming #138

cezaraugusto opened this issue Sep 10, 2018 · 0 comments
Assignees
Labels
Milestone

Comments

@cezaraugusto
Copy link
Member

@cezaraugusto cezaraugusto commented Sep 10, 2018

theming is made via props by theme provider and should not be hard-coded.

from @petemill in #134 (review)

To support themeing correctly, we shouldn't call 1 specific theme directly in the style files, but rely on the root <ThemeProvider and simply use props.theme.x which are provided by the ThemeProvider. See the <Button component as an example of how to define Prop types with typescript for styled-components to automatically get the compiler OK for these props, and good intellisense.

I agree

@cezaraugusto cezaraugusto self-assigned this Sep 10, 2018
cezaraugusto added a commit that referenced this issue Sep 10, 2018
fix #138
@cezaraugusto cezaraugusto added this to the 0.24.0 milestone Sep 10, 2018
@rossmoody rossmoody added the themes label Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.