Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme Containers #145

Open
petemill opened this issue Sep 12, 2018 · 1 comment
Open

Theme Containers #145

petemill opened this issue Sep 12, 2018 · 1 comment
Assignees
Labels

Comments

@petemill
Copy link
Member

@petemill petemill commented Sep 12, 2018

Goals

  • Allow user to select dark and light
  • Allow designer to specify always-dark areas

Needs

  • Know which areas can change between dark and light
  • Know which areas are always-dark
  • Know which areas are always-light

Method

  • Each core component needs to be able to be dark or light.
  • Each layout area needs to specify whether it is:
    • Changeable to dark and light
      • child components
      • background
    • Always dark
    • Always light
@petemill petemill self-assigned this Sep 12, 2018
@rossmoody rossmoody added the themes label Feb 4, 2019
@petemill
Copy link
Member Author

@petemill petemill commented Feb 6, 2019

Here's what this proposal could look like:

<ThemeContainer user-choice>
   ...stuff that can be dark or light with one of the 'standard' theme backgrounds...
  <ThemeContainer always-dark style="background: [something custom]">
     …stuff that is always in 'dark theme'… 
  </ThemeContainer>
   ...stuff that can be dark or light with one of the 'standard' theme backgrounds...
</ThemeContainer>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.