Skip to content

/ brave-ui

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add dialog component #16

Closed
cezaraugusto opened this issue Jan 26, 2018 · 6 comments
Closed

add dialog component #16

cezaraugusto opened this issue Jan 26, 2018 · 6 comments
Assignees
@cezaraugusto
Labels
component/dialog new component

Comments

@cezaraugusto
Copy link
Member

@cezaraugusto cezaraugusto commented Jan 26, 2018

No description provided.

@cezaraugusto cezaraugusto self-assigned this Jan 26, 2018
@cezaraugusto cezaraugusto added this to the v0.10.0 milestone May 2, 2018
@cezaraugusto cezaraugusto added this to For Payments Page in Brave Design System May 2, 2018
@ras9841
Copy link

@ras9841 ras9841 commented Jun 29, 2018 •
edited

Hey! Has someone picked this up? I'm an engineer looking to get involved with the Brave project.
@cezaraugusto
Copy link
Member Author

@cezaraugusto cezaraugusto commented Jul 2, 2018

hey @ras9841 that's great, thanks for your interest!

cc @NejcZdovc as he's adding some new components and can confirm if dialog is included as well
@NejcZdovc
Copy link
Member

@NejcZdovc NejcZdovc commented Jul 2, 2018

@cezaraugusto @ras9841 I am in process of already adding it
@ras9841
Copy link

@ras9841 ras9841 commented Jul 2, 2018

Thanks for the update! @NejcZdovc, are there other components I could help build?
@cezaraugusto
Copy link
Member Author

@cezaraugusto cezaraugusto commented Aug 10, 2018

Hi @ras9841 sorry for the long delay to answer.

Unfortunately, there's no component to work on right now as we are waiting on the brand design to implement them and the others are already in progress.

I'll follow up with you once we have something to work on if you're still interested. Thanks!
@cezaraugusto
Copy link
Member Author

@cezaraugusto cezaraugusto commented Aug 22, 2018

this is done already so closing. thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
component/dialog new component
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@cezaraugusto @ras9841 @NejcZdovc
You can’t perform that action at this time.