Skip to content

/ brave-ui

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

travis improvements #17

Closed
diracdeltas opened this issue Feb 22, 2018 · 0 comments
Closed

travis improvements #17

diracdeltas opened this issue Feb 22, 2018 · 0 comments

Comments

@diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Feb 22, 2018

the travis "passing" badge in https://github.com/brave/brave-ui just links to https://github.com/brave/brave-ui itself. it should link to https://travis-ci.org/brave/brave-ui.

travis seems to only run the tests; it should also run lint and security tests

travis also appears to be using out-of-date node and npm versions btw
cezaraugusto pushed a commit that referenced this issue Feb 22, 2018
Cezar Augusto
CI improvements
Unverified
No user is associated with the committer email.
Learn about signing commits
Loading status checks…
5cc97f7 
close #17
-
* badge now links to Travis
* run node on latest
* run check-security
* run lint
* run CI against master only
@cezaraugusto cezaraugusto mentioned this issue Feb 22, 2018
Merged
cezaraugusto pushed a commit that referenced this issue Feb 22, 2018
Cezar Augusto
CI improvements
Unverified
No user is associated with the committer email.
Learn about signing commits
Loading status checks…
c798753 
close #17
-
* badge now links to Travis
* run node on latest
* run check-security
* run lint
* run CI against master only
cezaraugusto pushed a commit that referenced this issue Mar 7, 2018
Cezar Augusto
CI improvements
Unverified
No user is associated with the committer email.
Learn about signing commits
22bd387 
close #17
-
* badge now links to Travis
* run node on latest
* run check-security
* run lint
* run CI against master only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

CI improvements
1 participant
@diracdeltas
You can’t perform that action at this time.