Skip to content

/ brave-ui

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Box component should not use flex for settings display #170

Closed
ryanml opened this issue Oct 1, 2018 · 0 comments
Closed

Box component should not use flex for settings display #170

ryanml opened this issue Oct 1, 2018 · 0 comments
Assignees
@ryanml

Comments

@ryanml
Copy link
Member

@ryanml ryanml commented Oct 1, 2018

It should be a simple/show hide with a transition of some sort. This way we can remove overflow:hidden from the component.
@ryanml ryanml self-assigned this Oct 1, 2018
ryanml added a commit to ryanml/brave-ui that referenced this issue Oct 1, 2018
@ryanml
Fixes brave#170, not using flex transition for Box
f1225ae
ryanml added a commit to ryanml/brave-ui that referenced this issue Oct 1, 2018
@ryanml
Fixes brave#170, not using flex transition for Box
c4cb21d
ryanml added a commit to ryanml/brave-ui that referenced this issue Oct 1, 2018
@ryanml
Fixes brave#170, not using flex transition for Box
a8aedbd
@NejcZdovc NejcZdovc closed this in 9922fba Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanml ryanml

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@ryanml
You can’t perform that action at this time.