Skip to content

/ brave-ui

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button click handlers are running twice #197

Closed
petemill opened this issue Oct 11, 2018 · 3 comments
Closed

Button click handlers are running twice #197

petemill opened this issue Oct 11, 2018 · 3 comments
Assignees
@petemill

Comments

@petemill
Copy link
Member

@petemill petemill commented Oct 11, 2018

No description provided.

@petemill petemill self-assigned this Oct 11, 2018
@petemill petemill mentioned this issue Oct 11, 2018
Merged
11 of 21 tasks complete
petemill added a commit that referenced this issue Oct 14, 2018
@petemill
only handle Button onClick once
Loading status checks…
51dc020 
Fix #197
@petemill petemill mentioned this issue Oct 14, 2018
Merged
@kjozwiak
Copy link
Member

@kjozwiak kjozwiak commented Oct 15, 2018

@petemill @NejcZdovc can you please add the appropriate labels and a milestone when you have the time? Was this fixed for 0.55.x?
@NejcZdovc
Copy link
Member

@NejcZdovc NejcZdovc commented Oct 15, 2018

yes this is for 0.55.x. We don't have labels and milestones in brave-ui
@kjozwiak
Copy link
Member

@kjozwiak kjozwiak commented Oct 15, 2018

@NejcZdovc didn't notice until now that his was in the brave-ui repo! Apologies.
@yrliou yrliou mentioned this issue Oct 17, 2018
Closed
NejcZdovc pushed a commit to brave/brave-core that referenced this issue Sep 18, 2019
@petemill
only handle Button onClick once
0c4c917 
Fix brave/brave-ui#197
NejcZdovc pushed a commit to brave/brave-core that referenced this issue Sep 19, 2019
@petemill
Imported from brave-ui: only handle Button onClick once
e43b506 
Fix brave/brave-ui#197
NejcZdovc added a commit to brave/brave-core that referenced this issue Sep 19, 2019
@petemill @NejcZdovc
Imported from brave-ui: only handle Button onClick once
Verified
This commit was signed with a verified signature.
NejcZdovc Nejc Zdovc
GPG key ID: F55DDADFE8E43B0F Learn about signing commits
649af21 
Fix brave/brave-ui#197
NejcZdovc added a commit to brave/brave-core that referenced this issue Sep 19, 2019
@petemill @NejcZdovc
Rewards: Imported from brave-ui: only handle Button onClick once
0417b54 
Fix brave/brave-ui#197
NejcZdovc added a commit to brave/brave-core that referenced this issue Sep 19, 2019
@petemill @NejcZdovc
Rewards: Imported from brave-ui: only handle Button onClick once
Verified
This commit was signed with a verified signature.
NejcZdovc Nejc Zdovc
GPG key ID: F55DDADFE8E43B0F Learn about signing commits
d07b79c 
Fix brave/brave-ui#197
NejcZdovc added a commit to brave/brave-core that referenced this issue Sep 19, 2019
@petemill @NejcZdovc
Rewards: Imported from brave-ui: only handle Button onClick once
Verified
This commit was signed with a verified signature.
NejcZdovc Nejc Zdovc
GPG key ID: F55DDADFE8E43B0F Learn about signing commits
de8311f 
Fix brave/brave-ui#197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petemill petemill

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@petemill @kjozwiak @NejcZdovc
You can’t perform that action at this time.