Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create mobile rewards toggle component #198

Closed
ryanml opened this issue Oct 11, 2018 · 2 comments
Closed

Create mobile rewards toggle component #198

ryanml opened this issue Oct 11, 2018 · 2 comments
Assignees

Comments

@ryanml
Copy link
Member

@ryanml ryanml commented Oct 11, 2018

This will be a fixed position sticky toggle that persists at the top as you scroll in the main settings page. It will break out of the settings page container and stay full width.

Pictured as the first item here:

screen shot 2018-10-11 at 3 11 30 pm

@ryanml ryanml self-assigned this Oct 11, 2018
@ryanml ryanml changed the title Create mobile main rewards toggle component Create mobile rewards toggle component Oct 11, 2018
@petemill
Copy link
Member

@petemill petemill commented Oct 11, 2018

@ryanml before we get too far with this, it looks like we just have a fixed-size mock-up here. Have you discussed with a designer how this looks on the larger android displays?

@ryanml
Copy link
Member Author

@ryanml ryanml commented Oct 12, 2018

@petemill I discussed with @jenn-rhim / @anthonypkeane , there is going to be a maximum content width of 800px for tablet (similar for example to how you have content constraints on chrome://settings). So the look of this component will not deviate much as it appears in the design.

ryanml added a commit to ryanml/brave-ui that referenced this issue Oct 12, 2018
ryanml added a commit to ryanml/brave-ui that referenced this issue Oct 15, 2018
ryanml added a commit to ryanml/brave-ui that referenced this issue Oct 15, 2018
@ryanml ryanml closed this in #199 Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.