Skip to content

/ brave-ui

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add translation for OK for notifications in wallet #218

Open
NejcZdovc opened this issue Oct 17, 2018 · 3 comments
Open

Add translation for OK for notifications in wallet #218

NejcZdovc opened this issue Oct 17, 2018 · 3 comments

Comments

@NejcZdovc
Copy link
Member

@NejcZdovc NejcZdovc commented Oct 17, 2018

removed here #217
@rossmoody rossmoody closed this Feb 4, 2019
@NejcZdovc
Copy link
Member Author

@NejcZdovc NejcZdovc commented Feb 5, 2019

@rossmoody was this one fixed?
@rossmoody
Copy link
Contributor

@rossmoody rossmoody commented Feb 5, 2019

I prob should have pinged first, I saw this one and it said "Fixes OK Translation" so I thought this was just out of date: brave/brave-core#661
@NejcZdovc
Copy link
Member Author

@NejcZdovc NejcZdovc commented Feb 5, 2019

brave/brave-core#661 implements 217 which reverts translation. This issue tracks this revert which needs to be reverted back. Will reopen it
@NejcZdovc NejcZdovc reopened this Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@NejcZdovc @rossmoody
You can’t perform that action at this time.