Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwitchButton improvements #24

Closed
cezaraugusto opened this issue May 1, 2018 · 0 comments
Closed

SwitchButton improvements #24

cezaraugusto opened this issue May 1, 2018 · 0 comments
Assignees
Labels
Milestone

Comments

@cezaraugusto
Copy link
Member

@cezaraugusto cezaraugusto commented May 1, 2018

@petemill shared https://codepen.io/rakeizer/pen/QQRBoZ which is a cool way to make the switch simpler which we can adapt and use. This makes the component logic and styles easier to understand.

We also need to add large prop as seem on private new tab page.

This issue should track un-skipping tests for switchButton as well.

@cezaraugusto cezaraugusto self-assigned this May 1, 2018
@cezaraugusto cezaraugusto added this to the v0.8.0 milestone May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.