Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiled output does not allow import destructuring #264

Closed
petemill opened this issue Nov 5, 2018 · 0 comments
Closed

Compiled output does not allow import destructuring #264

petemill opened this issue Nov 5, 2018 · 0 comments
Assignees
Labels

Comments

@petemill
Copy link
Member

@petemill petemill commented Nov 5, 2018

You can't do `import { Button } from 'brave-ui' because of the way that we are compiling in commonjs but expecting it to work like es-modules

It's probably ok to leave the module syntax alone, since any consumer would need to use typescript or webpack anyway, which supports this syntax. This can be fixed in tsconfig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.