Skip to content

/ brave-ui

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree shaking is not working #265

Closed
petemill opened this issue Nov 5, 2018 · 0 comments
Closed

Tree shaking is not working #265

petemill opened this issue Nov 5, 2018 · 0 comments
Assignees
@petemill
Labels
performance

Comments

@petemill
Copy link
Member

@petemill petemill commented Nov 5, 2018

When importing a component, icon or most things anywhere in brave-ui structure, the resulting webpack bundle includes most things in brave-ui, resulting in several hundred kb.

Test plan: example app in optimize/tree-shaking branch
@petemill petemill added the performance label Nov 5, 2018
@petemill petemill self-assigned this Nov 5, 2018
@petemill petemill mentioned this issue Nov 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petemill petemill

Labels
performance
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@petemill
You can’t perform that action at this time.