Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upLarge SVGs in Rewards should be external asset #267
Assignees
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are some large ~50kb assets that are included in the bundle. These would benefit from being external assets to consuming bundle sizes (especially valid on Android).
Inline SVGs are very useful when they are component-like, or for some other reason need to be styled with CSS. These assets seem like graphics and therefore do not need to be included. If they did, then I would suggest using
import()orReact.lazy()syntax so that they are contained in a different JS file.