Skip to content

/ brave-ui

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that amount related functions expect string type #298

Closed
ryanml opened this issue Nov 30, 2018 · 0 comments
Closed

Ensure that amount related functions expect string type #298

ryanml opened this issue Nov 30, 2018 · 0 comments
Assignees
@ryanml

Comments

@ryanml
Copy link
Member

@ryanml ryanml commented Nov 30, 2018

This overhaul was originally done here:

#194

Integration tests are currently failing:
screen shot 2018-11-30 at 12 23 38 am

Amount types should be changed to string, integration tests should pass, and UI should work with amount as expected.
@ryanml ryanml self-assigned this Nov 30, 2018
ryanml added a commit to ryanml/brave-ui that referenced this issue Nov 30, 2018
@ryanml
Fixes brave#298, uses string type for amount/tokens
c79530c
@ryanml ryanml mentioned this issue Nov 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanml ryanml

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Uses string type for amount/tokens
1 participant
@ryanml
You can’t perform that action at this time.