Skip to content

/ brave-ui

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make components themable #34

Closed
cezaraugusto opened this issue May 24, 2018 · 1 comment
Closed

make components themable #34

cezaraugusto opened this issue May 24, 2018 · 1 comment
Assignees
@cezaraugusto
Labels
architecture
Milestone
v0.10.0

Comments

@cezaraugusto
Copy link
Member

@cezaraugusto cezaraugusto commented May 24, 2018 •
edited

it's silly to pass down props such as "color" when ThemeProvider and theme allow us to use a cleaner and easier syntax.

This bumps the minor.

Tasks:
@cezaraugusto cezaraugusto added this to the v0.12.0 milestone May 24, 2018
@cezaraugusto cezaraugusto self-assigned this May 24, 2018
@cezaraugusto cezaraugusto modified the milestones: v0.12.0, v0.10.0 May 24, 2018
@cezaraugusto cezaraugusto changed the title make use of Theme and ThemeProvider make components themable May 24, 2018
cezaraugusto added a commit that referenced this issue May 25, 2018
@cezaraugusto
allow theming for Anchor
Verified
This commit was signed with a verified signature.
cezaraugusto Cezar Augusto
GPG key ID: 0E7DEADAAEA84F33 Learn about signing commits
bbe7203 
address #34
cezaraugusto added a commit that referenced this issue May 25, 2018
@cezaraugusto
allow theming for BoxedContent
Verified
This commit was signed with a verified signature.
cezaraugusto Cezar Augusto
GPG key ID: 0E7DEADAAEA84F33 Learn about signing commits
634815f 
address #34
cezaraugusto added a commit that referenced this issue May 25, 2018
@cezaraugusto
allow theming for Clock
Verified
This commit was signed with a verified signature.
cezaraugusto Cezar Augusto
GPG key ID: 0E7DEADAAEA84F33 Learn about signing commits
763fead 
address #34
cezaraugusto added a commit that referenced this issue May 25, 2018
@cezaraugusto
allow theming for DataItem
Verified
This commit was signed with a verified signature.
cezaraugusto Cezar Augusto
GPG key ID: 0E7DEADAAEA84F33 Learn about signing commits
346cf1f 
address #34
cezaraugusto added a commit that referenced this issue May 25, 2018
@cezaraugusto
allow theming for Grid and Column
Verified
This commit was signed with a verified signature.
cezaraugusto Cezar Augusto
GPG key ID: 0E7DEADAAEA84F33 Learn about signing commits
ba59597 
address #34
cezaraugusto added a commit that referenced this issue May 25, 2018
@cezaraugusto
allow theming for Heading
Verified
This commit was signed with a verified signature.
cezaraugusto Cezar Augusto
GPG key ID: 0E7DEADAAEA84F33 Learn about signing commits
820b07b 
address #34
cezaraugusto added a commit that referenced this issue May 25, 2018
@cezaraugusto
allow theming for MediaContent
Verified
This commit was signed with a verified signature.
cezaraugusto Cezar Augusto
GPG key ID: 0E7DEADAAEA84F33 Learn about signing commits
ea8fb0a 
address #34
cezaraugusto added a commit that referenced this issue May 25, 2018
@cezaraugusto
allow theming for Page
Verified
This commit was signed with a verified signature.
cezaraugusto Cezar Augusto
GPG key ID: 0E7DEADAAEA84F33 Learn about signing commits
0643b3f 
address #34
cezaraugusto added a commit that referenced this issue May 25, 2018
@cezaraugusto
allow theming for Paragraph
Verified
This commit was signed with a verified signature.
cezaraugusto Cezar Augusto
GPG key ID: 0E7DEADAAEA84F33 Learn about signing commits
e437f9f 
address #34
cezaraugusto added a commit that referenced this issue May 25, 2018
@cezaraugusto
allow theming for TextLabel
Verified
This commit was signed with a verified signature.
cezaraugusto Cezar Augusto
GPG key ID: 0E7DEADAAEA84F33 Learn about signing commits
9cd7580 
address #34
cezaraugusto added a commit that referenced this issue May 25, 2018
@cezaraugusto
allow theming for UnstyledButton
Verified
This commit was signed with a verified signature.
cezaraugusto Cezar Augusto
GPG key ID: 0E7DEADAAEA84F33 Learn about signing commits
Loading status checks…
45ffba8 
address #34
cezaraugusto added a commit that referenced this issue May 25, 2018
@cezaraugusto
allow theming for PushButton
Verified
This commit was signed with a verified signature.
cezaraugusto Cezar Augusto
GPG key ID: 0E7DEADAAEA84F33 Learn about signing commits
bfdb910 
address #34
cezaraugusto added a commit that referenced this issue May 25, 2018
@cezaraugusto
allow theming for TextLabel
Verified
This commit was signed with a verified signature.
cezaraugusto Cezar Augusto
GPG key ID: 0E7DEADAAEA84F33 Learn about signing commits
3c6064a 
address #34
cezaraugusto added a commit that referenced this issue May 25, 2018
@cezaraugusto
allow theming for UnstyledButton
Verified
This commit was signed with a verified signature.
cezaraugusto Cezar Augusto
GPG key ID: 0E7DEADAAEA84F33 Learn about signing commits
dc2efc8 
address #34
@cezaraugusto
Copy link
Member Author

@cezaraugusto cezaraugusto commented May 25, 2018

closed after 9e6c374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
architecture
Projects
None yet
Milestone
  v0.10.0
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@cezaraugusto
You can’t perform that action at this time.