Skip to content

/ brave-ui

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate toggle component instances #364

Closed
rossmoody opened this issue Feb 4, 2019 · 0 comments
Closed

Consolidate toggle component instances #364

rossmoody opened this issue Feb 4, 2019 · 0 comments
Labels
component/toggle refactor
Projects
Brave UI Release Tracking

Comments

@rossmoody
Copy link
Contributor

@rossmoody rossmoody commented Feb 4, 2019

There are duplicate toggle component definitions within Sync and Brave UI. We should consolidate them to one. From my little bit of investigation it looks like they behave a little differently with onChange or onClick.
@rossmoody rossmoody added this to In Queue in Brave UI Release Tracking Feb 6, 2019
@rossmoody rossmoody closed this Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/toggle refactor
Projects
Brave UI Release Tracking
Backlog
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@rossmoody
You can’t perform that action at this time.