Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brand containers #370

Open
petemill opened this issue Feb 6, 2019 · 0 comments
Open

Brand containers #370

petemill opened this issue Feb 6, 2019 · 0 comments

Comments

@petemill
Copy link
Member

@petemill petemill commented Feb 6, 2019

Goals

  • Allow designer to specify areas which are themed according to sub-brands

Needs

  • Know which areas which will have Brave / Rewards / Publishers 'look'

Method

  • Each core component needs to be able to be Brave or Rewards (or maybe Publishers). Default to Brave. For example:
    • Button's accent variant
    • Toggle's on variant
    • Text which is accent
  • Any layout area can specify whether all descendant Brave-UI controls change their brand default to Rewards or Publishers.

e.g. on it's own, Toggle and Button could be forced in to a brand via:

<div>
  <Toggle brand="Rewards" />
  <Button brand="Rewards" type="accent" level="primary" text="Save" />
</div>

...but it could be inside a new BrandContainer component which would change it automatically:

<BrandContainer brand="Rewards">
  <Toggle />
  <Button type="accent" level="primary" text="Save" />
</BrandContainer>
@rossmoody rossmoody added the themes label Feb 6, 2019
@rossmoody rossmoody added this to In Queue in Brave UI Release Tracking Feb 6, 2019
@rossmoody rossmoody moved this from In Queue to In Progress in Brave UI Release Tracking Feb 6, 2019
@rossmoody rossmoody removed this from In Progress in Brave UI Release Tracking Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.