Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep component folder hierarchy flat #397

Closed
rossmoody opened this issue Mar 1, 2019 · 1 comment
Closed

Keep component folder hierarchy flat #397

rossmoody opened this issue Mar 1, 2019 · 1 comment
Labels

Comments

@rossmoody
Copy link
Contributor

@rossmoody rossmoody commented Mar 1, 2019

Keeping component directory flat and the names singular. I think in the long run it might be a more understandable structure for importing/navigating to have the components be in a flat level instead of within nested folders within the components directory. Might be subjective but I find myself drilling down into and out of folders a lot.

Few Examples

components/buttonsIndicators/buttoncomponents/button
dataTables/tabletable
popupModals/alertBoxalertBox
popupModals/modalmodal

@rossmoody rossmoody added the refactor label Mar 1, 2019
@petemill
Copy link
Member

@petemill petemill commented Mar 1, 2019

We can make this backwards compatible by moving the files and keeping the old files which simply re-export from the new path.

@rossmoody rossmoody mentioned this issue Mar 2, 2019
@rossmoody rossmoody closed this Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.