Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and automate license attribution #398

Closed
rossmoody opened this issue Mar 1, 2019 · 1 comment
Closed

Update and automate license attribution #398

rossmoody opened this issue Mar 1, 2019 · 1 comment

Comments

@rossmoody
Copy link
Contributor

@rossmoody rossmoody commented Mar 1, 2019

We have to keep the license at the top of each file. We can use the one we are currently using or the one being used in Core. Since the one we are using is 3 lines and the one in core is 4, I think we should stick to what we have. My proposal is to move it to use

//

image

instead of

/* */

image

for the ridiculous reason that I find it nicer to look at with the left justified slashes.

Additionaly, I wonder if there is some type of automated process to ensure this license is added with a single space underneath via a pre-determined selection of folders? i.e. everything in src get this attribution snippet added in some way via automation.

@petemill
Copy link
Member

@petemill petemill commented Mar 1, 2019

You can use a commit hook. But in the scheme of things, this probably isn't worth changing every file. Just enforce as we introduce new files.

Also, the worst offender in this IMO is the uppercase 'Y' mid-sentence 😠

@rossmoody rossmoody closed this Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.