Skip to content

/ brave-ui

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

theming should provide a global outline color option #545

Open
cezaraugusto opened this issue Oct 8, 2019 · 0 comments · May be fixed by #546
Open

theming should provide a global outline color option #545

cezaraugusto opened this issue Oct 8, 2019 · 0 comments · May be fixed by #546
Assignees
@cezaraugusto

Comments

@cezaraugusto
Copy link
Member

@cezaraugusto cezaraugusto commented Oct 8, 2019

Outline color need to change based on user current theme. Right now the theme system provides no mechanism for that. We should do it.

Also, we should revert changes in #544 back to the original. See Pete's comments for more info.
@cezaraugusto cezaraugusto self-assigned this Oct 8, 2019
@cezaraugusto cezaraugusto mentioned this issue Oct 8, 2019
Merged
cezaraugusto added a commit that referenced this issue Oct 8, 2019
@cezaraugusto
add outlineColor as a global theme property
Loading status checks…
6adbf2d 
fix #545
@cezaraugusto cezaraugusto linked a pull request that will close this issue Oct 8, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

add outlineColor as a global theme property
1 participant
@cezaraugusto
You can’t perform that action at this time.