Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign updeprecate extend method #133
Merged
Conversation
closes #127
|
++ lgtm |
| @@ -60,6 +60,6 @@ export const CaratLeftIcon = RotatedIconComponent(CaratIcon, 90) | |||
| export const CaratUpIcon = RotatedIconComponent(CaratIcon, 180) | |||
| export const CaratDownIcon = CaratIcon | |||
| import ThumbsUpIcon from './thumbs-up' | |||
| export const ThumbsDownIcom = ThumbsUpIcon.extend` | |||
| export const ThumbsDownIcom = styled(ThumbsUpIcon)` | |||
This comment has been minimized.
This comment has been minimized.
jasonrsadler
Sep 7, 2018
Contributor
nit: spelling. ThumbsDownIcon (although if it's already used extensively, might save for another time)
This comment has been minimized.
This comment has been minimized.
|
Permalink to this PR: https://brave-ui-rfdkgzytxb.now.sh |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
cezaraugusto commentedSep 7, 2018
closes #127