Skip to content

/ brave-ui

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let onRestore prop be optional in modalContribute #150

Closed
wants to merge 1 commit into from
Closed

let onRestore prop be optional in modalContribute #150

wants to merge 1 commit into from

Conversation

@cezaraugusto
Copy link
Member

cezaraugusto commented Sep 12, 2018

fix #149

component interface says that onRestore is required (see here) but implementation doesn't use it (see here).
@cezaraugusto
let onRestore prop be optional in modalContribute
Verified
This commit was signed with a verified signature.
cezaraugusto Cezar Augusto
GPG key ID: 0E7DEADAAEA84F33 Learn about signing commits
Loading status checks…
b3013a3 
fix #149
@cezaraugusto cezaraugusto self-assigned this Sep 12, 2018
@cezaraugusto cezaraugusto requested review from ryanml and jasonrsadler Sep 12, 2018
@cezaraugusto
Copy link
Member Author

cezaraugusto commented Sep 12, 2018

#147 fixes this so I'm going to close
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanml ryanml

@jasonrsadler jasonrsadler

Assignees

@cezaraugusto cezaraugusto

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

unable to run npm run `storybook-deploy`
1 participant
@cezaraugusto
You can’t perform that action at this time.