Skip to content

/ brave-ui

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing monthlyAmount prop to string #292

Merged
merged 1 commit into from Nov 27, 2018
Merged

Changing monthlyAmount prop to string #292

merged 1 commit into from Nov 27, 2018

Conversation

@ryanml
Copy link
Member

ryanml commented Nov 27, 2018 •
edited

Fixes: #291
To be used by: brave/brave-core#957

Before (monthlyAmount={10})
screen shot 2018-11-26 at 7 55 47 pm

After (monthlyAmount={'10.0'})
screen shot 2018-11-26 at 7 55 51 pm
@ryanml
Fixes #291, monthlyAmount -> string
Loading status checks…
3901636
@ryanml ryanml self-assigned this Nov 27, 2018
@ryanml ryanml requested review from petemill, NejcZdovc and cezaraugusto Nov 27, 2018
@petemill
petemill approved these changes Nov 27, 2018
View changes
@petemill petemill merged commit bbc429b into brave:master Nov 27, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petemill petemill

@cezaraugusto cezaraugusto

@NejcZdovc NejcZdovc

Assignees

@ryanml ryanml

Labels
PR/pending-review
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@ryanml @petemill
You can’t perform that action at this time.