Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing "Set as default browser" from the settings menu #1495

Closed
kjozwiak opened this issue Apr 23, 2019 · 2 comments

Comments

@kjozwiak
Copy link
Member

commented Apr 23, 2019

Description

When you already have Brave set as the default browser, you basically have a menu item that is greyed out that's completely useless and taking up space. When you view the settings menu while on a webpage, it's pretty large already, last thing we need is a menu item that is completely useless and taking up space. I personally think we should remove it from the settings page and add it somewhere within the Settings (not the menu).

Steps to reproduce

  1. Install 1.0.91 CR: 73.0.3683.90 and make Brave the default browser

Actual result

Screenshot_20190422-223552_Brave

Expected result

We shouldn't be including a dead link/UI component in the settings menu.

Issue reproduces how often

100% reproducible using the STR mentioned above

Issue happens on

  • Current Play Store version? Yes, reproducible using 1.0.91 CR: 73.0.3683.90
  • Beta build? N/A (haven't tried beta but assuming the issue is still present)

Device details

  • Install type (ARM, x86): ARM
  • Device (Phone, Tablet, Phablet): Samsung S10+ & Pixel 2 XL
  • Android version: Android 9

Brave version

Used 1.0.91 CR: 73.0.3683.90

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

@SergeyZhukovsky

This comment has been minimized.

Copy link
Member

commented Jun 20, 2019

It is done here #1734

@srirambv

This comment has been minimized.

Copy link
Collaborator

commented Jun 20, 2019

  • Verification passed on Samsung Tab running 1.0.99 x64 build
    • Verified setting Chrome as the default browser, shows the Set default browser option in the hamburger menu
    • Verified selecting the option from hamburger menu and setting Brave as the default browser, the option is removed from the hamburger menu

Verification passed on BraveModernarm v1.0.99-rc.1 on Samsung s7.

Verified passed with 1.0.99rc1 BraveModernx86.apk on Asus Zenfone (x86).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.