Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

old forward button being displayed in some cases - follow up to 911 #1748

Closed
LaurenWags opened this issue Jun 20, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@LaurenWags
Copy link

commented Jun 20, 2019

Description

Follow up to #911

In some cases the old forward button is being displayed in the UI.

Steps to reproduce

Scenario 1

  1. Clean install of 1.0.99rc1.
  2. Tap on hamburger menu, see new forward button.
  3. Change phone orientation to landscape.
  4. Tap on hamburger menu. Old forward button is displayed.

Scenario 2

  1. Follow scenario 1 above or clean install 1.0.99rc1.
  2. Turn off bottom toolbar.
  3. Make sure phone is portrait orientation, tap on hamburger menu. Old forward button is displayed.

Actual result

Old forward button is displayed.
Scenario 1:
Screenshot_20190620-152754

Scenario 2:
Screenshot_20190620-153729

Expected result

New forward button is displayed.
Screenshot_20190620-152726

Issue reproduces how often

easily

Issue happens on

  • Current Play Store version? n/a
  • Beta build? 1.0.99rc1

Device details

  • Install type (ARM, x86): all
  • Device (Phone, Tablet, Phablet): phone
  • Android version: all

Brave version

1.0.99rc1

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional information

@LaurenWags

This comment has been minimized.

Copy link
Author

commented Jun 21, 2019

Verified passed with Asus Zenfone (x86) running 1.0.99rc2 BraveModernx86.apk
Scenario 1:
Screenshot_20190621-112842
Scenario 2:
Screenshot_20190621-112903

  • Verification passed on Huawei P20 running 1.0.99 RC2 x64build
    Scenario 1 (Normal tab):
    Screenshot_20190621-114743

Scenario 2 (Normal tab):
Screenshot_20190621-114757

  • Verified on Private tabs as well
  • Verification passed on Samsung Galaxy j3 version 5.1.1 running BraveModernarm 1.0.99 RC2
  • Verified on both Normal and Private tabs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.