Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields counter post 1000 blocked items #1879

Closed
SergeyZhukovsky opened this issue Jul 25, 2019 · 4 comments

Comments

@SergeyZhukovsky
Copy link
Member

commented Jul 25, 2019

Currently there is no room to show 4 digits number there and it looks like 100 when it passes 1000 blocked items. We should either write 1K there or make a smaller fonts when it passes that value.
https://twitter.com/i/status/1154011294258716672

@deeppandya

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

@SergeyZhukovsky This issue is irrelevant because of : #1837

@deeppandya

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

Closing this issue as it's irrelevant with new UI for brave shield panel. #1837

@deeppandya deeppandya closed this Aug 29, 2019
@deeppandya

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

Reopening this issue as we are not going to change the UI for brave shield right now.

@srirambv

This comment has been minimized.

Copy link
Collaborator

commented Sep 17, 2019

Verification passed on OnePlust 6T with Android 9.0 running 1.4.0

  • Verified stats counter uses .k once it crosses 1000 blocked items
    image

Verification passed on Asus Zenfone (x86) with Android 6.0 running 1.4.0 rc3 BraveModernx86.apk

  • Verified stats counter uses K once it crosses 1000 blocked items
    Screenshot_20190925-104304

Verification passed on Samsung Tab A with Android 9.0 running 1.4.0 rc4 x64

  • Verified stats counter uses .k once it crosses 1000 blocked items
    image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.