Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search engine selection #2014

Closed
anthonypkeane opened this issue Aug 28, 2019 · 2 comments

Comments

@anthonypkeane
Copy link
Collaborator

commented Aug 28, 2019

Description

Please make DuckDuckGo (not DuckDuckGo lite) the default search engine in the following new countries:

  • Germany
  • Australia
  • New Zealand
  • Ireland

This is for NEW users only

Onboarding will need to be updated

@LaurenWags

This comment has been minimized.

Copy link

commented Sep 25, 2019

Verification passed on Asus Zenfone (x86) with Android 6.0 running 1.4.0 rc3 BraveModernx86.apk

  • For Germany, Australia, NZ, and Ireland, verified the following:

    • New install has DDG (not DDG lite) as the default SE for both normal and private tabs
    • Installed 1.3.2, left default SE. Upgraded to 1.4.0rc3 and verified that SE for both normal and private tabs remained unchanged from previous version.
    • Installed 1.3.2, changed default SE for both normal and private tabs. Upgraded to 1.4.0rc3 and verified that SE for both normal and private tabs remained unchanged from previous version.
  • For other regions (US, GB), verified the following:

    • Clean install of 1.4.0rc3, verified SE was not DDG (normal and private tabs)
    • Installed 1.3.2, left default SE. Upgraded to 1.4.0rc3 and verified that SE for both normal and private tabs remained unchanged from previous version.
    • Installed 1.3.2, changed default SE for both normal and private tabs. Upgraded to 1.4.0rc3 and verified that SE for both normal and private tabs remained unchanged from previous version.
  • Encountered #2097 once, but was unable to reproduce

  • Unable to verify Onboarding as x86 does not have this.

@srirambv

This comment has been minimized.

Copy link
Collaborator

commented Sep 25, 2019

Verification passed on OnePlus 6T with Android 9.0 running 1.4.0 rc3 x64 build

  • Clean install on Germany/Ireland/New Zealand/Australia
    • Clean install starts onboarding and has DDG selected as default SE
    • Skip onboarding retains DDG as default for normal and private tabs
    • Select a different SE during onboarding changes to the selected SE for both normal/private tabs
  • Upgrade on Germany/Ireland/New Zealand/Australia
    • Verified custom SE from previous install is retained on upgrade
    • Verified DDG popup modal shows up on upgrade when default SE is different via upgrade
    • Verified default SE from previous version is retained on upgrade
    • Verified DDG popup modal shows up on upgrade when default SE from onboarding is kept
  • Logged #2103 for DDG modal not showing up when a different SE is set during onboarding

Verification passed on Samsung Tab A with Android 9.0 running 1.4.0 RC4 x64 build

  • Clean install on Germany/Ireland/New Zealand/Australia
    • Clean install starts onboarding and has DDG selected as default SE
    • Skip onboarding retains DDG as default for normal and private tabs
    • Select a different SE during onboarding changes to the selected SE for both normal/private tabs
  • Upgrade on Germany/Ireland/New Zealand/Australia
    • Verified custom SE from the previous install is retained on upgrade
    • Verified DDG popup modal shows up on upgrade when default SE is different via upgrade
    • Verified default SE from previous version is retained on upgrade
    • Verified DDG popup modal shows up on upgrade when default SE from onboarding is kept
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.