Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAP not being used under "brave://rewards/#rewards-summary" #2272

Closed
kjozwiak opened this issue Nov 8, 2019 · 4 comments

Comments

@kjozwiak
Copy link
Member

@kjozwiak kjozwiak commented Nov 8, 2019

Description

BAT is s till being used under brave://rewards/#rewards-summary rather than BAP

Steps to reproduce

  1. set the device locale to Japanese
  2. install 1.5.0 CR: 78.0.3904.90 and switch to staging (accept the grant)
  3. using the grant, tip https://duckduckgo.com
  4. go into brave://rewards and tap on Your wallet so it opens brave://rewards/#rewards-summary

Actual result

Screenshot_20191107-220051

Screenshot_20191107-221533

Expected result

Should be using BAP instead of BAT as per the specification.

Issue reproduces how often

100% reproducible when going through the above STR.

Issue happens on

  • Current Play Store version? N/A
  • Beta build? Yes, reproducible using 1.5.0 CR: 78.0.3904.90`

Device details

  • Install type (ARM, x86): ARM
  • Device (Phone, Tablet, Phablet): Pixel 2 XL
  • Android version: Android 10

Brave version

  • 1.5.0 CR: 78.0.3904.90

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

CCing @anthonypkeane @SergeyZhukovsky @samartnik @brave/legacy_qa

@GeetaSarvadnya

This comment has been minimized.

Copy link
Collaborator

@GeetaSarvadnya GeetaSarvadnya commented Nov 8, 2019

Reproduced in Samsung Galaxy J3 version 5..1.1 running Bravemodernarm 1.5.0-rc3
image

@btlechowski

This comment has been minimized.

Copy link

@btlechowski btlechowski commented Nov 8, 2019

Reproduced on BraveModernarm v1.5.0-rc.3 on Huawei MediaPad M3 Lite 10 (Android 7.0).
Screenshot_20191108-092740

@anthonypkeane anthonypkeane assigned deeppandya and ryanml and unassigned deeppandya Nov 8, 2019
@samartnik

This comment has been minimized.

Copy link
Collaborator

@samartnik samartnik commented Nov 9, 2019

@kjozwiak

This comment has been minimized.

Copy link
Member Author

@kjozwiak kjozwiak commented Nov 12, 2019

Verification PASSED on Pixel 2 XL running Android 10 using https://github.com/brave/browser-android-tabs/releases/tag/v1.5.1-rc.1.

Screenshot_20191112-015146


Verification passed on Samsung Tab A with Android 9.0 running 1.5.1 x64 build
image

Verification passed on BraveModernarm v1.5.1-rc.1 on Samsung s7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.