Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should be using "BAT Points" under "brave://rewards" & "brave://rewards/#rewards-summary" #2274

Closed
kjozwiak opened this issue Nov 8, 2019 · 2 comments

Comments

@kjozwiak
Copy link
Member

@kjozwiak kjozwiak commented Nov 8, 2019

Description

We should be using BAT Points rather than BAP under Your wallet in both brave://rewards & brave://rewards/#rewards-summary

Steps to reproduce

  1. set the device locale to Japanese
  2. install 1.5.0 CR: 78.0.3904.90 and switch to staging (accept the grant)
  3. using the grant, tip https://duckduckgo.com
  4. go into brave://rewards and tap on Your wallet so it opens brave://rewards/#rewards-summary

Actual result

Screenshot_20191107-223641

Screenshot_20191107-223645

Screenshot_20191107-223736

Screenshot_20191107-223740

Expected result

Screenshot_20191107-223650

Screenshot_20191107-223712

Screenshot_20191107-223749

Screenshot_20191107-223756

Issue reproduces how often

100% reproducible when going through the above STR.

Issue happens on

  • Current Play Store version? N/A
  • Beta build? Yes, reproducible using 1.5.0 CR: 78.0.3904.90`

Device details

  • Install type (ARM, x86): ARM
  • Device (Phone, Tablet, Phablet): Pixel 2 XL
  • Android version: Android 10

Brave version

  • 1.5.0 CR: 78.0.3904.90

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

CCing @anthonypkeane @SergeyZhukovsky @samartnik @brave/legacy_qa

@kjozwiak kjozwiak added this to the 1.5.0 milestone Nov 8, 2019
@kjozwiak kjozwiak changed the title should be using `BAT Points` under "brave://rewards" & "brave://rewards/#rewards-summary" should be using "BAT Points" under "brave://rewards" & "brave://rewards/#rewards-summary" Nov 8, 2019
@kjozwiak

This comment has been minimized.

Copy link
Member Author

@kjozwiak kjozwiak commented Nov 8, 2019

@anthonypkeane this could use a confirmation from product. Seems like we should be using BAT Points rather than BAP so it matches the other screens when displaying the main balance. We're basically using BAT Points in the Reward panels viewing websites but displaying BAP under both brave://rewards & brave://rewards/#rewards-summary.

@kjozwiak

This comment has been minimized.

Copy link
Member Author

@kjozwiak kjozwiak commented Nov 12, 2019

Verification PASSED on Pixel 2 XL running Android 10 using https://github.com/brave/browser-android-tabs/releases/tag/v1.5.1-rc.1.

Screenshot_20191112-015753
Screenshot_20191112-015811


Verification passed on Samsung Tab A with Android 9.0 running 1.5.1 x64 build
image
image

Verification passed on BraveModernarm v1.5.1-rc.1 on Samsung s7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.