Skip to content
This repository has been archived by the owner. It is now read-only.

Sync'd bookmark favicon is shown only after opening the page #762

Closed
srirambv opened this issue Mar 26, 2017 · 2 comments
Closed

Sync'd bookmark favicon is shown only after opening the page #762

srirambv opened this issue Mar 26, 2017 · 2 comments

Comments

@srirambv
Copy link
Contributor

@srirambv srirambv commented Mar 26, 2017

Description:
Sync'd bookmark favicon is shown only after opening the page

Did you search for similar issues before submitting this one?
Yes

Expected behavior:
Should load the favicon of the site when the bookmark is sync'd

  • Device (iPhone5, iPhone6s plus, iPad 3, ?):
    iPhone 6 (iOS 10)

  • Brave Version:
    1.4.1

  • Steps to reproduce:

    1. Enable sync on desktop and add few bookmarks
    2. Sync iPhone with the laptop using the QRCode
    3. Bookmarks are synced without favicons. Favicons are loaded only when the bookmark is loaded

** Website problems only:

  • did you check with Brave Shields down?

  • did you check in Puffin/Dolphin/iCab/Maxthon (UIWebView-based browsers)?

  • Screenshot if needed:
    image

  • Any related issues:

@srirambv srirambv added this to the 1.4 milestone Mar 26, 2017
@jhreis jhreis modified the milestones: 1.4, 1.3.2 Apr 12, 2017
@jhreis
Copy link
Collaborator

@jhreis jhreis commented May 2, 2017

We currently now have a default placeholder icon. Although not ideal, this will be v1 for sync, so pushing this.

@jhreis jhreis modified the milestones: 1.4.1, 1.4 May 2, 2017
@jhreis jhreis modified the milestones: 1.4.1, 1.5 Jun 2, 2017
@srirambv
Copy link
Contributor Author

@srirambv srirambv commented Jun 19, 2017

Closing in favour of brave/sync#106

@srirambv srirambv closed this Jun 19, 2017
@srirambv srirambv removed this from the 1.5 milestone Oct 2, 2017
@srirambv srirambv added this to the Sync v2 milestone Apr 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.