Skip to content
This repository has been archived by the owner. It is now read-only.

No network connection error message shown when trying to sync offline but enable sync #927

Closed
srirambv opened this issue Jun 19, 2017 · 2 comments
Assignees
Milestone

Comments

@srirambv
Copy link
Contributor

@srirambv srirambv commented Jun 19, 2017

Did you search for similar issues before submitting this one?
Yes

Description:
No network connection error message shown when trying to sync offline

Device (iPhone5, iPhone6s plus, iPad 3, ?):
iPhone 7+ (iOS 10.3.3) - Pyramid 1
iPhone 6 (iOS 10.3.3) - Pyramid 0

Brave Version:
1.4(17.06.15.13)

Steps to reproduce:
1. Enable Sync on device 1(iPhone 6) which is connected to internet
2. On device 2(iPhone 7+) disconnect from internet and type in the code words shown on device 1(iPhone 6)
3. Sync loading spinner is shown for ~40 seconds and then goes back to Enter code words screen, No network error message is shown
4. Tap on Sync button, Goes back to sync main menu and shows the sync is enabled

Actual Behavior
No network connection error message shown when trying to sync offline but enable sync

Expected Behavior
Should show network error message and should not sync

Is this an issue with Beta build?
Yes

Is this an issue in the currently released version?
N/A

Can this issue be consistently reproduced?
Yes

Extra QA steps:
1.
2.
3.

Screenshot if needed:

Any related issues:
cc: @ayumi @diracdeltas @jamesmudgett

@srirambv
Copy link
Contributor Author

@srirambv srirambv commented Jun 19, 2017

Closing in favour of brave/sync#103

@LaurenWags
Copy link

@LaurenWags LaurenWags commented Jul 31, 2017

Removing milestone per standup call

@srirambv srirambv added this to the Sync v2 milestone Apr 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.