New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitwarden: Site autofill doesn't work #10140

Closed
srirambv opened this Issue Jul 26, 2017 · 8 comments

Comments

@srirambv
Collaborator

srirambv commented Jul 26, 2017

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    bitwarden: Site autofill doesn't work

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):

Brave 0.18.12
rev 2ca400c
Muon 4.3.6
  • Steps to reproduce:

    1. Clean install 0.18.12
    2. Enable bitwarden and login to your account
    3. Visit a site with saved credentials, right click -> autofill -> credentials nothing happens
  • Actual result:
    Site autofill doesn't work

  • Expected result:
    Should autofill credentials and login

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    N/A

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:

@kspearrin

This comment has been minimized.

Show comment
Hide comment
@kspearrin

kspearrin Jul 31, 2017

Contributor

See #10202 for more details, but this is happening because of missing APIs on chrome.contextMenus

Contributor

kspearrin commented Jul 31, 2017

See #10202 for more details, but this is happening because of missing APIs on chrome.contextMenus

@jonathansampson

This comment has been minimized.

Show comment
Hide comment
@jonathansampson

jonathansampson Jul 31, 2017

Collaborator

Working on this now with @kevinlawler. We've identified the needed fix, and are working towards resolving.

Collaborator

jonathansampson commented Jul 31, 2017

Working on this now with @kevinlawler. We've identified the needed fix, and are working towards resolving.

@jonathansampson

This comment has been minimized.

Show comment
Hide comment
@jonathansampson

jonathansampson Aug 1, 2017

Collaborator

The following resolves this issue, but likely isn't ideal. @kevinlawler, can you suggest a better place to make a similar modification?

diff --git a/js/contextMenus.js b/js/contextMenus.js
index 7095bd4..5555868 100644
--- a/js/contextMenus.js
+++ b/js/contextMenus.js
@@ -1174,6 +1174,9 @@ function mainTemplateInit (nodeProps, frame, tab) {
               label: extensionContextMenu.properties.title,
               click: (item, focusedWindow) => {
                 if (focusedWindow) {
+                  if (extensionContextMenu.properties.parentId) {
+                    info.parentMenuItemId = extensionContextMenu.properties.parentId
+                  }
                   extensionActions.contextMenuClicked(
                     extensionContextMenu.extensionId, frame.get('tabId'), info)
                 }
Collaborator

jonathansampson commented Aug 1, 2017

The following resolves this issue, but likely isn't ideal. @kevinlawler, can you suggest a better place to make a similar modification?

diff --git a/js/contextMenus.js b/js/contextMenus.js
index 7095bd4..5555868 100644
--- a/js/contextMenus.js
+++ b/js/contextMenus.js
@@ -1174,6 +1174,9 @@ function mainTemplateInit (nodeProps, frame, tab) {
               label: extensionContextMenu.properties.title,
               click: (item, focusedWindow) => {
                 if (focusedWindow) {
+                  if (extensionContextMenu.properties.parentId) {
+                    info.parentMenuItemId = extensionContextMenu.properties.parentId
+                  }
                   extensionActions.contextMenuClicked(
                     extensionContextMenu.extensionId, frame.get('tabId'), info)
                 }
@kevinlawler

This comment has been minimized.

Show comment
Hide comment
@kevinlawler

kevinlawler Aug 1, 2017

Contributor

Seems fine to me. If there's a better place I don't know where it is.

Contributor

kevinlawler commented Aug 1, 2017

Seems fine to me. If there's a better place I don't know where it is.

@jonathansampson

This comment has been minimized.

Show comment
Hide comment
@jonathansampson

jonathansampson Aug 1, 2017

Collaborator

@kevinlawler I'm going to look at adding it here:

contextMenuCreated: (state, action) => {

Collaborator

jonathansampson commented Aug 1, 2017

@kevinlawler I'm going to look at adding it here:

contextMenuCreated: (state, action) => {

@darkdh

This comment has been minimized.

Show comment
Hide comment
@darkdh

darkdh Aug 1, 2017

Member

@jonathansampson extensionState would be the perfect place to add.

Member

darkdh commented Aug 1, 2017

@jonathansampson extensionState would be the perfect place to add.

@jonathansampson

This comment has been minimized.

Show comment
Hide comment
@jonathansampson

jonathansampson Aug 1, 2017

Collaborator

@darkdh Working on adding it there. I just issued a PR to first optimize much of extensionState, and assigned it to you for review :)

Collaborator

jonathansampson commented Aug 1, 2017

@darkdh Working on adding it there. I just issued a PR to first optimize much of extensionState, and assigned it to you for review :)

@alexwykoff alexwykoff modified the milestones: 0.19.x (Beta Channel), 0.18.x Hotfix Aug 8, 2017

@jonathansampson

This comment has been minimized.

Show comment
Hide comment
@jonathansampson

jonathansampson Aug 16, 2017

Collaborator

I believe I now have a fix for this, and will be opening a PR momentarily.

Collaborator

jonathansampson commented Aug 16, 2017

I believe I now have a fix for this, and will be opening a PR momentarily.

@jonathansampson jonathansampson self-assigned this Aug 16, 2017

@jonathansampson jonathansampson referenced this issue Aug 16, 2017

Merged

Add parentMenuItemId info property #10519

4 of 5 tasks complete

@luixxiul luixxiul modified the milestones: 0.18.x Hotfix, 0.19.x (Beta Channel) Aug 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment