Skip to content
This repository has been archived by the owner. It is now read-only.

cannot sort by publisher verification status in about:preferences#payments #10752

Closed
diracdeltas opened this issue Aug 31, 2017 · 4 comments
Closed

Comments

@diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Aug 31, 2017

Test Plan

  • visit several websites that are verified (vice.com, theguardian.com, duckduckgo.com, coindesk.com)
  • populate the ledger table with about 10 other media/websites that aren't verified
  • ensure that you can sorta via descending and ascending order when clicking on verified column
  • ensure that you can sorta via descending and ascending order when clicking on site column
  • ensure that you can sorta via descending and ascending order when clicking on include column
  • ensure that you can sorta via descending and ascending order when clicking on views column
  • ensure that you can sorta via descending and ascending order when clicking on time spent column
  • ensure that you can sorta via descending and ascending order when clicking on % column
  • ensure that you cannot sorta via the actions column

Original Bug

  • Did you search for similar issues before submitting this one?
    yes

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macos

  • Brave Version (revision SHA):
    0.18.23

  • Steps to reproduce:

    1. go to about:preferences#payments
    2. click on the first column header to sort by publisher verification status
  • Actual result:

the table is not sorted

  • Expected result:

the table should be sorted

  • Is this an issue in the currently released version?
    yes

  • Can this issue be consistently reproduced?
    yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:

@diracdeltas diracdeltas added this to the 0.21.x (Nightly Channel) milestone Aug 31, 2017
@alexwykoff alexwykoff removed this from the 0.21.x (Nightly Channel) milestone Sep 12, 2017
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@NejcZdovc NejcZdovc modified the milestones: Triage Backlog, 0.20.x Hotfix 1 Jan 20, 2018
@NejcZdovc NejcZdovc self-assigned this Jan 20, 2018
@arsalankhalid
Copy link
Contributor

@arsalankhalid arsalankhalid commented Feb 4, 2018

Pretty sure this issue should be closed now, no?

@NejcZdovc
Copy link
Member

@NejcZdovc NejcZdovc commented Feb 4, 2018

It will be closed when we merge #12750, but we need to wait until correct milestone is up before merging

@alexwykoff alexwykoff modified the milestones: 0.20.x Hotfix 3 (Ledger improvments), 0.21.x (Beta Channel) Feb 6, 2018
NejcZdovc added a commit that referenced this issue Feb 7, 2018
…sort

Fixes Issue #10752, allows for sorting by publisher verification
NejcZdovc added a commit that referenced this issue Feb 7, 2018
…sort

Fixes Issue #10752, allows for sorting by publisher verification
NejcZdovc added a commit that referenced this issue Feb 7, 2018
…sort

Fixes Issue #10752, allows for sorting by publisher verification
@srirambv
Copy link
Collaborator

@srirambv srirambv commented Feb 21, 2018

Works fine on Windows
10752

@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Beta Channel), 0.21.x (Twitch) Feb 24, 2018
NejcZdovc added a commit that referenced this issue Feb 24, 2018
…sort

Fixes Issue #10752, allows for sorting by publisher verification
@LaurenWags
Copy link

@LaurenWags LaurenWags commented Feb 26, 2018

Removed QA/checked labels due to changes in milestones. Please recheck with 0.21.15 and higher.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.