This repository has been archived by the owner. It is now read-only.

Security webdriver tests failing #10825

Closed
NejcZdovc opened this Issue Sep 6, 2017 · 3 comments

Comments

@NejcZdovc
Copy link
Member

NejcZdovc commented Sep 6, 2017

Describe the issue you encountered:

  13) noscript can allow scripts when the url host is an ipv6 address:
     Promise was rejected with the following reason: timeout
  Error

@diracdeltas can you please check if this is a problem in the test or we regressed

@NejcZdovc NejcZdovc added this to the 0.21.x (Nightly Channel) milestone Sep 6, 2017

@NejcZdovc NejcZdovc changed the title noscript for ipv6 is failing Security webdiver tests failing Sep 6, 2017

@NejcZdovc

This comment has been minimized.

Copy link
Member

NejcZdovc commented Sep 6, 2017

please check this one as well

 16) navigationBar tests navigation tabnapping updates the location in the navbar when changed by the opener:
     Promise was rejected with the following reason: timeout
  Error
@NejcZdovc

This comment has been minimized.

Copy link
Member

NejcZdovc commented Sep 6, 2017

  11) Bravery Panel Adblock stats without iframe tests blocks websocket tracking:
     Error: element ("#result") still not visible after 10000ms
      at elements("#result") - isVisible.js:54:17
      at isVisible("#result") - waitForVisible.js:73:22

Problem with this test is that wss://wss.websocketstest.com:443/service return error

websockets.html:10 WebSocket connection to 'wss://wss.websocketstest.com/service' failed: Error in connection establishment: net::ERR_CONNECTION_REFUSED

@diracdeltas

This comment has been minimized.

Copy link
Member

diracdeltas commented Sep 7, 2017

the noscript ipv6 failure is an actual regression, appears to be caused by the switch to muon.url.parse. i think brave/muon#300 will fix it

diracdeltas added a commit that referenced this issue Sep 7, 2017

use muon's IP address check instead of node's
partial fix for #10825 (noscript allowing scripts when host is an ipv6 address)

Test Plan:
1. npm run test -- --grep='can allow scripts when the url host is an ipv6 address' (the test is skipped on travis due to lack of ipv6 support)

@luixxiul luixxiul changed the title Security webdiver tests failing Security webdriver tests failing Sep 8, 2017

@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.