Skip to content
This repository has been archived by the owner. It is now read-only.

past contribution statements change when the ledger synopsis changes #11306

Closed
diracdeltas opened this issue Oct 5, 2017 · 7 comments
Closed

past contribution statements change when the ledger synopsis changes #11306

diracdeltas opened this issue Oct 5, 2017 · 7 comments

Comments

@diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Oct 5, 2017

Brave: 0.19.29
rev: c10b3ea
Muon: 4.4.25
libchromiumcontent: 61.0.3163.100
V8: 6.1.534.41
Node.js: 7.9.0
Update Channel: Beta
OS Platform: macOS
OS Release: 15.6.0
OS Architecture: x64

After updating to the latest beta, I noticed 2 issues in about:preferences#payments:

  1. All my Brave contribution statements show $5 going to a single site. For instance this is the August contribution statement:
    screen shot 2017-10-05 at 11 47 52 pm
    I'm 99% sure that before this release, my contribution statements all had multiple sites.

  2. The synopsis table also only shows one site
    screen shot 2017-10-05 at 11 50 28 pm

cc @bsclifton

@diracdeltas
Copy link
Member Author

@diracdeltas diracdeltas commented Oct 6, 2017

btw i had these settings turned on:
screen shot 2017-10-06 at 6 39 09 pm

@NejcZdovc mentions that this behavior in 0.19.29 might be correct and the behavior prevoiusly was a bug. So perhaps this isn't a blocker

@ghost ghost added priority/P4 and removed priority/P1 labels Oct 6, 2017
@ghost
Copy link

@ghost ghost commented Oct 6, 2017

Adjusting priority labelling based on:

  • P1 - Blocks development or testing. Product cannot run.
  • P2 - Crashes. Loss of data. Severe memory leak.
  • P3 - Major loss of function.
  • P4 - Minor loss of function. Workaround usually present.
  • P5 - Cosmetic. Spelling, copy, layout.
@NejcZdovc
Copy link
Member

@NejcZdovc NejcZdovc commented Oct 6, 2017

yes before 0.19.29 we had a bug where setting values were renamed, which @bsclifton fixed in 0.19.29. Advance settings weren't applied to the ledger table correctly.

@diracdeltas
Copy link
Member Author

@diracdeltas diracdeltas commented Oct 6, 2017

So probably the only bug here is that it seems very weird that my payment history has changed (the user would assume the payments are already done by the time they appear in the contribution statement)

@NejcZdovc
Copy link
Member

@NejcZdovc NejcZdovc commented Oct 6, 2017

they shouldn't change, so this is a bug for sure

@diracdeltas diracdeltas changed the title payments history is missing all except 1 entry past contribution statements change when the ledger synopsis changes Oct 6, 2017
@NejcZdovc NejcZdovc added the needs-STR label Oct 10, 2017
@NejcZdovc NejcZdovc modified the milestones: 0.19.x (Beta Channel), 0.19.x Release 2 (Beta Channel) Oct 11, 2017
@NejcZdovc
Copy link
Member

@NejcZdovc NejcZdovc commented Oct 11, 2017

not sure if related or not #11447. Pushing it back to 0.19 2, because we don't have STR

@alexwykoff
Copy link
Contributor

@alexwykoff alexwykoff commented Oct 24, 2017

Closing due to lack of STR or signal from support

@alexwykoff alexwykoff closed this Oct 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
@diracdeltas @bbondy @alexwykoff @bsclifton @NejcZdovc and others
You can’t perform that action at this time.