Skip to content
This repository has been archived by the owner. It is now read-only.

With many tabs, adding a bookmark is slow #11425

Closed
ayumi opened this issue Oct 10, 2017 · 0 comments
Closed

With many tabs, adding a bookmark is slow #11425

ayumi opened this issue Oct 10, 2017 · 0 comments

Comments

@ayumi
Copy link
Contributor

@ayumi ayumi commented Oct 10, 2017

Description

On a user profile which has 100 unique tabs, the time to bookmark a page via the toolbar bookmark star is significantly slower vs bookmark time on a fresh profile (~2000 ms vs 1000 ms)

Steps to Reproduce

Automated test (feature/perf-tests branch): https://github.com/brave/browser-laptop/pull/10517/files#diff-f741809427f0fd392187bcbcbef3ce44

  1. Start Brave
  2. Open 100 tabs each with unique URLs. (A quick way to do this is via Import bookmarks -> Bookmarks manager -> Right click a folder -> Open all in tabs)
  3. Close Brave
  4. Open Brave. It should remember the 100 tabs.
  5. Navigate to a URL like example.com.
  6. Click the bookmark star to add a bookmark, and see how long it takes.

Actual result:
Much slower with many tabs.

Expected result:
Similar speed to a fresh profile

Reproduces how often:
Always in the perf tests

Brave Version

master 29bdbd5

Reproducible on current live release:

Additional Information

screen shot 2017-10-10 at 20 41 22

@ayumi ayumi added the perf label Oct 10, 2017
@ayumi ayumi added this to the 0.20.x (Developer Channel) milestone Oct 10, 2017
@alexwykoff alexwykoff modified the milestones: 0.20.x (Beta Channel), 0.21.x (Developer Channel) Oct 24, 2017
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel), Backlog Oct 25, 2017
@NejcZdovc NejcZdovc modified the milestones: Triage Backlog, Backlog (Prioritized) Nov 21, 2017
@bsclifton bsclifton added the stale label Sep 3, 2018
@bsclifton bsclifton removed this from the Backlog (Prioritized) milestone Sep 3, 2018
@bsclifton bsclifton closed this Sep 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants
You can’t perform that action at this time.