This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up(minor) Tab performance - aphrodite stylesheets created during render #11465
Assignees
Milestone
Comments
petemill
added a commit
to petemill/browser-laptop
that referenced
this issue
Oct 11, 2017
Helps with performance, instead use css variables to pass js variables to css. Fix brave#11465
petemill
changed the title
petemill
added a commit
to petemill/browser-laptop
that referenced
this issue
Oct 11, 2017
Helps with performance, instead use css variables to pass js variables to css. Fix brave#11465
petemill
added a commit
to petemill/browser-laptop
that referenced
this issue
Oct 12, 2017
Helps with performance, instead use css variables to pass js variables to css. Fix brave#11465
petemill
added a commit
to petemill/browser-laptop
that referenced
this issue
Oct 12, 2017
Helps with performance, instead use css variables to pass js variables to css. Fix brave#11465
petemill
added a commit
to petemill/browser-laptop
that referenced
this issue
Oct 13, 2017
Helps with performance, instead use css variables to pass js variables to css. Fix brave#11465
petemill
added a commit
to petemill/browser-laptop
that referenced
this issue
Oct 13, 2017
Helps with performance, instead use css variables to pass js variables to css. Fix brave#11465
cezaraugusto
added
QA/no-qa-needed
release-notes/exclude
and removed
PR/pending-review
release-notes/exclude
labels
|
note for QA team: while this is a refactor this is also related to performance so please put something related in release notes, I'm setting for 0.22.x. Thanks |
syuan100
added a commit
to syuan100/browser-laptop
that referenced
this issue
Nov 9, 2017
Helps with performance, instead use css variables to pass js variables to css. Fix brave#11465
|
Moved to milestone 0.22.x due to requiring it for a clean merge of #12565 and the same / similar test plan for that version. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
Some of the components used to render tabs are calling Stylesheet.create on every render() call. This was introduced in f9b2a2c which was the tab component module split (#8347, #8348). This can create a lot of unnecessary css rules added to the document, and maybe even unnecessary paints.
Affected components:
tab.js
favIcon.js
tabIcon.js
Brave Version
master - introduced in f9b2a2c
Reproducible on current live release: Affected code not yet deployed to master